Add CI check that builds with latest Expo #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates CI to build and run the full CLI to create an app against the latest version of Expo. The test then
cd
s into the new app and runs the tests and linters in the new app to verify the new app is valid.This addresses two shortcomings of the current approach and test coverage:
create-expo-app
orreact-native init
command. This lowers the maintenance burden of this library and ensures users always get the latest versions of RN or Expo. But it is a bit brittle, since a new RN or Expo version might potentially break the CLI. These tests provide a way to ensure the CLI still works. Eventually, I'd like to set this up to run automatically on a cadence (eg. daily). This way, we would know quickly if a new version breaks the CLI.